Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Scene example: write file in a task #5952

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - Scene example: write file in a task #5952

wants to merge 5 commits into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Wrap file writing in a task

@mockersf mockersf mentioned this pull request Sep 11, 2022
Closed
@mockersf mockersf added C-Examples An addition or correction to our examples A-Scenes Serialized ECS data stored on the disk labels Sep 11, 2022
@rparrett
Copy link
Contributor

This might be slightly silly, but do you think it would be a good idea to mention in a comment that this doesn't work on the web?

@mockersf
Copy link
Member Author

This might be slightly silly, but do you think it would be a good idea to mention in a comment that this doesn't work on the web?

Good point! added a comment and disabled that part in wasm

@mockersf @tim-blackbird
english
1ed1ed6 
Co-authored-by: ira <[email protected]>
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 11, 2022
@alice-i-cecile
Copy link
Member

Thank you very much @mockersf; I agree that this is a better pattern to teach.

@alice-i-cecile alice-i-cecile added this to the Bevy 0.9 milestone Sep 11, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Sep 12, 2022
@mockersf
Scene example: write file in a task (#5952)
1b97205 
# Objective

- Fix #5951 
- Improve on #5949 by not risking blocking a system

## Solution

- Wrap file writing in a task
@bors
Copy link
Contributor

bors bot commented Sep 12, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Scene example: write file in a task [Merged by Bors] - Scene example: write file in a task Sep 12, 2022
@bors bors bot closed this Sep 12, 2022
nicopap pushed a commit to nicopap/bevy that referenced this pull request Sep 12, 2022
@mockersf @nicopap
Scene example: write file in a task (bevyengine#5952)
c1bbab5 
# Objective

- Fix bevyengine#5951 
- Improve on bevyengine#5949 by not risking blocking a system

## Solution

- Wrap file writing in a task
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
@mockersf @james7132
Scene example: write file in a task (bevyengine#5952)
cab6ae8 
# Objective

- Fix bevyengine#5951 
- Improve on bevyengine#5949 by not risking blocking a system

## Solution

- Wrap file writing in a task
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
Scene example: write file in a task (bevyengine#5952)
29b1be0 
# Objective

- Fix bevyengine#5951 
- Improve on bevyengine#5949 by not risking blocking a system

## Solution

- Wrap file writing in a task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tim-blackbird tim-blackbird tim-blackbird approved these changes

@rparrett rparrett rparrett approved these changes

@afonsolage afonsolage afonsolage approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@IceSentry IceSentry IceSentry approved these changes

Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
Bevy 0.9
Development

Successfully merging this pull request may close these issues.

Revert change to scene saving example to demonstrate async API
6 participants
@mockersf @rparrett @alice-i-cecile @afonsolage @IceSentry @tim-blackbird